pull: Update key loading function to match error style
authorColin Walters <walters@verbum.org>
Sun, 5 Apr 2020 18:22:49 +0000 (18:22 +0000)
committerColin Walters <walters@verbum.org>
Sun, 5 Apr 2020 18:49:25 +0000 (18:49 +0000)
commit47539874b8e5259040a11a79b3c155e633fcae34
tree5771a29abe324b49d3c7dac451c9bb39fb86f70b
parenta16fe86b3695a997bab7814d9de63f7e09f07e93
pull: Update key loading function to match error style

This code wasn't written with idiomatic GError usage; it's not standard
to construct an error up front and continually append to its
message.  The exit from a function is usually `return TRUE`,
with error conditions before that.

Updating it to match style reveals what I think is a bug;
we were silently ignoring failure to parse key files.
src/libostree/ostree-repo-pull.c
tests/test-signed-pull.sh